Add metric sources UI and custom alert targets (metric alerts phase 2) - #340
Merged
Conversation
Project-level /metrics-sources list, set form, and detail chart; a Custom tab on matching deployment metrics; and an alert target-kind toggle for custom metric-source series. Preview nav. Mock fixtures and Playwright coverage for list statuses, set payload, chart banners, and custom alerts.
|
Preview deleted (PR closed). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 of metric alerts: scrape-source config, custom charts, and custom alert targets.
What
/metrics-sources, preview nav after Alerts): list (name, location/deployment, port, path, status), set form (create+edit; deployment + port + path, no URL), and detail (series table +RangeSwitch+Chart.svelte). Truncated/error banners fromtruncated/lastError.kind: custom,source,series, metricvalue|rate). Custom payloads omitlocation/deployment. Default remains deployment so existing create tests keep sending{ location, deployment }withoutkind.Permissions use
GuardedButton/can('metricSource.set')(and get/list/delete).Screenshots
Tests
bun run lint,bun run check, andbun run test(Playwright, 407 passed). Coverage includes:metricSource.setwith deployment+port+path (no url field)alert.createwithkind: customand no deploymentMock fixtures for
metricSource.{set,get,list,delete,series,query}(ok / truncated / scrape-error sources; gauge + counter series).